Thread (10 messages) 10 messages, 3 authors, 2021-02-25

Re: [PATCH v1 1/4] ACPI: processor: Get rid of ACPICA message printing

From: Hanjun Guo <guohanjun@huawei.com>
Date: 2021-02-25 14:18:50
Also in: linux-acpi, lkml

On 2021/2/25 2:06, Rafael J. Wysocki wrote:
On Tue, Feb 23, 2021 at 3:45 PM Rafael J. Wysocki [off-list ref] wrote:
quoted
On Tue, Feb 23, 2021 at 12:31 PM Hanjun Guo [off-list ref] wrote:
quoted
On 2021/2/23 2:59, Rafael J. Wysocki wrote:
quoted
Index: linux-pm/drivers/acpi/processor_idle.c
===================================================================
--- linux-pm.orig/drivers/acpi/processor_idle.c
+++ linux-pm/drivers/acpi/processor_idle.c
In this file, function acpi_processor_cstate_first_run_checks()
has a wrong pr_notice():

pr_notice("ACPI: processor limited to max C-state %d\n",
                 max_cstate);

Since we have pr_fmt() for this file, "ACPI:" is duplicate,
we'd better cleanup this as below:

pr_notice("processor limited to max C-state %d\n", max_cstate);
Thanks for pointing this out, I'll make this change when applying the patch.
Actually, this issue is not strictly related to the patch here, so I'm
going to send a separate patch to fix it.
Make sense to me as well.

Thanks
Hanjun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help