Re: [PATCH] Add CHARGE_NOW support to cw2015_battery.c

From
Tobias Schramm <t.schramm@manjaro.org>
Date
2021-02-16 15:32:54
Also in
lkml
Reply to
Tobias Schramm, 2021-02-16
Hi Martin,
thanks for the patch. Looks good and tests fine.
eh, scratch that. Didn't have my cup of morning coffee yet. The patch is fine as far as the code change goes. However it is missing a "Signed-off-by" line, certifying your authorship. git can generate that automagically for you with `git commit --signoff`.
quoted
CHARGE_NOW is expected by some user software (such as waybar)
instead of 'CAPACITY', in order to correctly calculate
remaining battery life.
There needs to be a "Signed-off-by" line right here.
quoted
---
  drivers/power/supply/cw2015_battery.c | 6 ++++++
  1 file changed, 6 insertions(+)
[ ... ]
Reviewed-by: Tobias Schramm <t.schramm@manjaro.org>
Review retracted.

Please resend the patch with the "Signed-off-by" line included. Then I can mark it as reviewed.


Sorry for the confusion,

Tobias Schramm
Thread (3 messages) 3 messages, 2 authors, last reply 2021-02-16
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help