Re: [PATCH v2 3/4] pps: Use subdir-ccflags-* to inherit debug flag
From: Rodolfo Giometti <giometti@enneenne.com>
Date: 2021-02-09 12:38:11
Also in:
linux-hwmon, linux-kbuild, lkml
On 09/02/21 12:08, Yicong Yang wrote:
quoted hunk ↗ jump to hunk
From: Junhao He <redacted> We use ccflags-$(CONFIG_PPS_DEBUG) for the debug message in drivers/pps, but the DEBUG flag will not pass to the subdirectory. Considering CONFIG_HWMON_DEBUG_CHIP intends to turn on debug recursively under driver/pps, so it will be clearer to use subdir-ccflags-* instead of ccflags-* to inherit the debug settings from Kconfig when traversing subdirectories. Suggested-by: Bjorn Helgaas <bhelgaas@google.com> Signed-off-by: Junhao He <redacted> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com> --- drivers/pps/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/pps/Makefile b/drivers/pps/Makefile index ceaf65c..7a2d3f7 100644 --- a/drivers/pps/Makefile +++ b/drivers/pps/Makefile@@ -8,4 +8,4 @@ pps_core-$(CONFIG_NTP_PPS) += kc.o obj-$(CONFIG_PPS) := pps_core.o obj-y += clients/ generators/ -ccflags-$(CONFIG_PPS_DEBUG) := -DDEBUG +subdir-ccflags-$(CONFIG_PPS_DEBUG) := -DDEBUG
Acked-by: Rodolfo Giometti <giometti@enneenne.com> -- GNU/Linux Solutions e-mail: giometti@enneenne.com Linux Device Driver giometti@linux.it Embedded Systems phone: +39 349 2432127 UNIX programming skype: rodolfo.giometti