Re: [PATCH 2/4] hwmon: Use subdir-ccflags-* to inherit debug flag
From: Guenter Roeck <linux@roeck-us.net>
Date: 2021-02-05 18:39:36
Also in:
linux-hwmon, linux-kbuild, lkml
On Fri, Feb 05, 2021 at 05:44:13PM +0800, Yicong Yang wrote:
From: Junhao He <redacted> Use subdir-ccflags-* instead of ccflags-* to inherit the debug settings from Kconfig when traversing subdirectories. Suggested-by: Bjorn Helgaas <bhelgaas@google.com> Signed-off-by: Junhao He <redacted> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
What problem does this fix ? Maybe I am missing it, but I don't see DEBUG being used in a subdirectory of drivers/hwmon. Guenter
quoted hunk ↗ jump to hunk
--- drivers/hwmon/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile index 09a86c5..1c0c089 100644 --- a/drivers/hwmon/Makefile +++ b/drivers/hwmon/Makefile@@ -201,5 +201,5 @@ obj-$(CONFIG_SENSORS_XGENE) += xgene-hwmon.o obj-$(CONFIG_SENSORS_OCC) += occ/ obj-$(CONFIG_PMBUS) += pmbus/ -ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG +subdir-ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG-- 2.8.1