On Jan 28, 2021, at 02:34, Rafael J. Wysocki [off-list ref] wrote:

On Wed, Dec 16, 2020 at 6:47 PM Chang S. Bae [off-list ref] wrote:

quoted

+       keybackup_status = read_keylocker_backup_status();
+       if (!(keybackup_status & BIT(0))) {
+               pr_err("x86/keylocker: internal key restoration failed with %s\n",
+                      (keybackup_status & BIT(2)) ? "read error" : "invalid status");
+               WARN_ON(1);
+               goto disable_keylocker;
+       }

The above conditional could be consolidated a bit by using WARN():

if (WARN(!(keybackup_status & BIT(0)), "x86/keylocker: internal key
restoration failed with %s\n",
       (keybackup_status & BIT(2)) ? "read error" : "invalid status")
               goto disable_keylocker;

Apart from this the patch LGTM.

Thanks for the review! I will make this change on my next revision.

Chang