On Mon, 2021-01-25 at 09:34 +0100, Peter Zijlstra wrote:

On Sun, Jan 24, 2021 at 04:30:57PM -0600, Michael Larabel wrote:

quoted

From ongoing tests of this patch, it still certainly shows to address most
of the Linux 5.11 performance regression previously encountered when using
Schedutil. Additionally, for a number of workloads where not seeing a
regression from 5.10 to 5.11 Git is still showing even better performance
with this patch. The power monitoring on the AMD EPYC server is showing
higher power spikes but the average power consumption rate is roughly
comparable to that of Linux 5.11 Git, which is higher than 5.10 by just
about 3%.

So this patch still seems to be working out well and indeed taking care of
some wide losses seen otherwise on Linux 5.11 when using Schedutil on AMD
Zen2/Zen3. Still have some other tests running but so far no unexpected
results.

Did you do all this writing and forget to add:

Tested-by: Michael Larabel <redacted>

?

Michael confirmed me off-list that yes, the patch should carry the
"Tested-by" tag with his name.


Giovanni