Re: [PATCH v1 3/6] leds: Add driver for Acer Iconia Tab A500

24.08.2020 01:30, Pavel Machek пишет:

Hi!

Hello, Pavel! Thank you very much for the review! I'll take into account
yours comments in the v2!

quoted

Acer Iconia Tab A500 is an Android tablet device which has two LEDs
embedded into the Power Button. Orange LED indicates "battery charging"
status and white LED indicates "wake-up/charge-done" status. The new LED
driver provides control over both LEDs to userspace.

quoted

@@ -0,0 +1,121 @@
+// SPDX-License-Identifier: GPL-2.0+

Nice.

quoted

+ * Copyright 2020 GRATE-driver project.

Probably untrue.

quoted

+	white_led->cdev.name = "power-button-white";

"white:power"

quoted

+	white_led->cdev.max_brightness = LED_ON;

= 1. (And you'll need other adjustments over the code).

quoted

+	orange_led->cdev.name = "power-button-orange";

"orange:power" -- or what is this LED usually used for?

quoted

+MODULE_LICENSE("GPL v2");

Should be "GPL"?

Yes, apparently it should be "GPL". I'll try to double-check it for the v2.

Thanks!