Re: [PATCH v4 08/16] thermal: sun8i: add TEMP_CALIB_MASK for calibration data in sun50i_h6_ths_calibrate
From: Frank Lee <tiny.windzz@gmail.com>
Date: 2020-07-20 09:27:44
Also in:
linux-arm-kernel, lkml
From: Frank Lee <tiny.windzz@gmail.com>
Date: 2020-07-20 09:27:44
Also in:
linux-arm-kernel, lkml
HI, On Fri, Jul 17, 2020 at 3:56 PM Daniel Lezcano [off-list ref] wrote:
On 17/07/2020 09:35, Frank Lee wrote:quoted
On Fri, Jul 17, 2020 at 12:26 PM Daniel Lezcano [off-list ref] wrote:quoted
On 14/07/2020 09:13, Frank Lee wrote:quoted
From: Yangtao Li <redacted> For sun50i_h6_ths_calibrate(), the data read from nvmem needs a round of calculation. On the other hand, the newer SOC may store other data in the space other than 12bit sensor data. Add mask operation to read data to avoid conversion error. Signed-off-by: Yangtao Li <redacted> Reviewed-by: Yangtao Li <tiny.windzz@gmail.com>Can you clarify these SoB ?Previously I used 'Signed-off-by: Yangtao Li [off-list ref]', maybe this should be removed directly?quoted
Frank Lee==Yangtao Li==frank@allwinnertech.com==tiny.windzz@gmail.com ?Yeah.You are not supposed to add reviewed-by yourself. Please remove it.
Should I resend the entire series or just the thermal patch? What about those that have been applied. Thx, Yangtao