Re: [PATCH v2 0/3] sched, arch_topology: Thermal pressure configuration cleanup
From: Vincent Guittot <vincent.guittot@linaro.org>
Date: 2020-07-13 12:03:22
Also in:
linux-arm-kernel, lkml
On Sun, 12 Jul 2020 at 18:59, Valentin Schneider [off-list ref] wrote:
Hi folks, This stems from this thread [1] on the list. TL;DR: the thermal pressure config has no helpful documentation, and figuring out if the right dependencies are in place is not easy for a regular user. The current landscape also paints an odd picture: arch_set_thermal_pressure() is hardcoded in sched/core.c, and is *not* architecture-definable, while arch_get_thermal_pressure() is. Patch 1 is tackling this, the rest is Kconfig stuff. Cheers, Valentin [1]: https://lkml.kernel.org/r/20200603173150.GB1551@shell.armlinux.org.uk Revisions ========= v1 -> v2 -------- o Remove cpufreq_cooling.c weak function; use #define stub in sched/topology.h (Vincent)
Looks good to me. Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
o Hinge arm SCHED_THERMAL_PRESSURE selection on ARM_CPU_TOPOLOGY Valentin Schneider (3): arch_topology, sched/core: Cleanup thermal pressure definition sched: Cleanup SCHED_THERMAL_PRESSURE kconfig entry arm, arm64: Select CONFIG_SCHED_THERMAL_PRESSURE arch/arm/Kconfig | 1 + arch/arm/include/asm/topology.h | 3 ++- arch/arm64/Kconfig | 1 + arch/arm64/include/asm/topology.h | 3 ++- drivers/base/arch_topology.c | 11 +++++++++++ include/linux/arch_topology.h | 4 ++-- include/linux/sched/topology.h | 7 +++++++ init/Kconfig | 15 ++++++++++++++- kernel/sched/core.c | 11 ----------- 9 files changed, 40 insertions(+), 16 deletions(-) -- 2.27.0