Re: [PATCH v4 5/7] iio: adc: exynos: Use input_device_enabled()
From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date: 2020-06-10 01:28:20
Also in:
linux-acpi, linux-arm-kernel, linux-iio, linux-input, linux-samsung-soc, linux-tegra, lkml, platform-driver-x86
On Mon, Jun 08, 2020 at 01:22:09PM +0200, Andrzej Pietrasiewicz wrote:
A new helper is available, so use it. Inspecting 'users' member of input_dev requires taking device's mutex.
[...]
quoted hunk ↗ jump to hunk
--- a/drivers/iio/adc/exynos_adc.c +++ b/drivers/iio/adc/exynos_adc.c@@ -633,7 +633,9 @@ static irqreturn_t exynos_ts_isr(int irq, void *dev_id) bool pressed; int ret; - while (info->input->users) { + mutex_lock(&info->input->mutex); + while (input_device_enabled(info->input)) { + mutex_unlock(&info->input->mutex); ret = exynos_read_s3c64xx_ts(dev, &x, &y); if (ret == -ETIMEDOUT) break;@@ -651,6 +653,8 @@ static irqreturn_t exynos_ts_isr(int irq, void *dev_id) input_sync(info->input); usleep_range(1000, 1100); + + mutex_lock(&info->input->mutex); }
Missed an mutex_unlock() here.
writel(0, ADC_V1_CLRINTPNDNUP(info->regs));
Best Regards, Michał Mirosław