[PATCH 1/2] opp: Reorder the code for !target_freq case
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2020-05-15 07:57:35
Also in:
lkml
Subsystem:
operating performance points (opp), the rest · Maintainers:
Viresh Kumar, Nishanth Menon, Stephen Boyd, Linus Torvalds
Reorder the code a bit to make it more readable. Add additional comment as well. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/opp/core.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/opp/core.c b/drivers/opp/core.c
index e4f01e7771a2..dda8164fad56 100644
--- a/drivers/opp/core.c
+++ b/drivers/opp/core.c@@ -817,15 +817,20 @@ int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq) } if (unlikely(!target_freq)) { - if (opp_table->required_opp_tables) { - ret = _set_required_opps(dev, opp_table, NULL); - } else if (!_get_opp_count(opp_table)) { + /* + * Some drivers need to support cases where some platforms may + * have OPP table for the device, while others don't and + * opp_set_rate() just needs to behave like clk_set_rate(). + */ + if (!_get_opp_count(opp_table)) return 0; - } else { + + if (!opp_table->required_opp_tables) { dev_err(dev, "target frequency can't be 0\n"); ret = -EINVAL; } + ret = _set_required_opps(dev, opp_table, NULL); goto put_opp_table; }
--
2.25.0.rc1.19.g042ed3e048af