Re: [PATCH 1/3] regulator: max14577: Add proper dt-compatible strings
flat view
From: Mark Brown <broonie@kernel.org>
Date: 2020-02-20 16:56:18
Also in:
lkml
On Thu, Feb 20, 2020 at 03:51:25PM +0100, Marek Szyprowski wrote:
Add device tree compatible strings and create proper modalias structures to let this driver load automatically if compiled as module, because max14577 MFD driver creates MFD cells with such compatible strings.
quoted hunk ↗ jump to hunk
+static const struct of_device_id of_max14577_regulator_dt_match[] = { + { .compatible = "maxim,max77836-regulator", + .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, }, + { .compatible = "maxim,max14577-regulator", + .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, },
Why would we want to encode the particular way Linux happens to represent regulators on a MFD into the DT binding? It's not clear that this is a generic thing (another OS might choose to have a separate object for each regulator with no parent for example) and the compatible isn't adding any information we didn't have already knowing about the parent device.
Attachments
- signature.asc [application/pgp-signature] 488 bytes