Re: [PATCH v17 01/14] bitops: Introduce the for_each_set_clump8 macro

From
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date
2019-10-09 17:09:25
Also in
linux-arch, linux-arm-kernel, linux-gpio, lkml
Reply to
Masahiro Yamada, 2019-10-09
On Thu, Oct 10, 2019 at 01:28:08AM +0900, Masahiro Yamada wrote:
On Thu, Oct 10, 2019 at 12:27 AM William Breathitt Gray
[off-list ref] wrote:
quoted
This macro iterates for each 8-bit group of bits (clump) with set bits,
within a bitmap memory region. For each iteration, "start" is set to the
bit offset of the found clump, while the respective clump value is
stored to the location pointed by "clump". Additionally, the
bitmap_get_value8 and bitmap_set_value8 functions are introduced to
respectively get and set an 8-bit value in a bitmap memory region.
Why is the return type "unsigned long" where you know
it return the 8-bit value ?
Because bitmap API operates on unsigned long type. This is not only
consistency, but for sake of flexibility in case we would like to introduce
more calls like clump16 or so.

Same comment for the rest.

-- 
With Best Regards,
Andy Shevchenko

Thread (29 messages) 29 messages, 5 authors, last reply 2019-10-10
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help