Re: [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver

On Thu, Aug 29, 2019 at 8:23 PM Stephen Boyd [off-list ref] wrote:

Quoting Amit Kucheria (2019-08-29 01:48:27)

quoted

On Wed, Aug 28, 2019 at 6:03 AM Stephen Boyd [off-list ref] wrote:

quoted

Quoting Amit Kucheria (2019-08-27 05:14:03)

quoted

Define two new required properties to define interrupts and
interrupt-names for tsens.

Signed-off-by: Amit Kucheria <redacted>
---
 Documentation/devicetree/bindings/thermal/qcom-tsens.txt | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.txt b/Documentation/devicetree/bindings/thermal/qcom-tsens.txt
index 673cc1831ee9d..686bede72f846 100644
--- a/Documentation/devicetree/bindings/thermal/qcom-tsens.txt
+++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.txt

@@ -22,6 +22,8 @@ Required properties:

 - #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description.
 - #qcom,sensors: Number of sensors in tsens block
+- interrupts: Interrupts generated from Always-On subsystem (AOSS)

Is it always one? interrupt-names makes it sound like it.

quoted

+- interrupt-names: Must be one of the following: "uplow", "critical"

Will fix to "one or more of the following"

Can we get a known quantity of interrupts for a particular compatible
string instead? Let's be as specific as possible. The index matters too,
so please list them in the order that is desired.

I *think* we can predict what platforms have uplow and critical
interrupts based on IP version currently[1]. For newer interrupt
types, we might need more fine-grained platform compatibles.

[1] Caveat: this is based only on the list of platforms I've currently
looked at, there might be something internally that breaks these
rules.