Thread (3 messages) 3 messages, 3 authors, 2018-12-17

Re: [PATCH] PM / AVS: SmartReflex: NULL check before some freeing functions is not needed.

From: Rafael J. Wysocki <hidden>
Date: 2018-12-17 11:46:20
Also in: lkml

On Tuesday, December 11, 2018 7:53:05 PM CET Kevin Hilman wrote:
Thomas Meyer [off-list ref] writes:
quoted
NULL check before some freeing functions is not needed.

Signed-off-by: Thomas Meyer <redacted>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
quoted
---

diff -u -p a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
--- a/drivers/power/avs/smartreflex.c
+++ b/drivers/power/avs/smartreflex.c
@@ -1010,8 +1010,7 @@ static int omap_sr_remove(struct platfor
 
 	if (sr_info->autocomp_active)
 		sr_stop_vddautocomp(sr_info);
-	if (sr_info->dbg_dir)
-		debugfs_remove_recursive(sr_info->dbg_dir);
+	debugfs_remove_recursive(sr_info->dbg_dir);
 
 	pm_runtime_disable(&pdev->dev);
 	list_del(&sr_info->node);
Patch applied, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help