-----Original Message-----
From: linux-kernel-owner@vger.kernel.org <linux-kernel-
owner@vger.kernel.org> On Behalf Of Shawn Guo
Sent: Monday, October 8, 2018 11:22 AM
To: Vabhav Sharma <redacted>
Cc: sudeep.holla@arm.com; oss@buserror.net; linux-kernel@vger.kernel.org;
devicetree@vger.kernel.org; robh+dt@kernel.org; mark.rutland@arm.com;
linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org;
mturquette@baylibre.com; sboyd@kernel.org; rjw@rjwysocki.net;
viresh.kumar@linaro.org; linux-clk@vger.kernel.org; linux-pm@vger.kernel.org;
linux-kernel-owner@vger.kernel.org; catalin.marinas@arm.com;
will.deacon@arm.com; gregkh@linuxfoundation.org; arnd@arndb.de;
kstewart@linuxfoundation.org; yamada.masahiro@socionext.com; Leo Li
[off-list ref]; linux@armlinux.org.uk; Varun Sethi [off-list ref];
Udit Kumar [off-list ref]; Pankaj Bansal [off-list ref];
Priyanka Jain [off-list ref]; Sriram Dash [off-list ref]
Subject: Re: [PATCH v4 6/6] arm64: dts: add LX2160ARDB board support

On Thu, Oct 04, 2018 at 06:33:51AM +0530, Vabhav Sharma wrote:

quoted

LX2160A reference design board (RDB) is a high-performance computing,
evaluation, and development platform with LX2160A SoC.

Signed-off-by: Priyanka Jain <redacted>
Signed-off-by: Sriram Dash <redacted>
Signed-off-by: Vabhav Sharma <redacted>
---
 arch/arm64/boot/dts/freescale/Makefile            |   1 +
 arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 100
++++++++++++++++++++++
 2 files changed, 101 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts

diff --git a/arch/arm64/boot/dts/freescale/Makefile

b/arch/arm64/boot/dts/freescale/Makefile
index 86e18ad..445b72b 100644

--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile

@@ -13,3 +13,4 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-

rdb.dtb

quoted

 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-simu.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-qds.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-rdb.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb

diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts

b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
new file mode 100644
index 0000000..1483071

--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts

@@ -0,0 +1,100 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT) // // Device Tree file
+for LX2160ARDB // // Copyright 2018 NXP
+
+/dts-v1/;
+
+#include "fsl-lx2160a.dtsi"
+
+/ {
+	model = "NXP Layerscape LX2160ARDB";
+	compatible = "fsl,lx2160a-rdb", "fsl,lx2160a";
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	sb_3v3: regulator-fixed {

The node name should probably be named like regulator-sb3v3 or something, so
that the pattern can be followed when we have another fixed regulator to be
added.

Ok, Agree this is fixed 3.3 standby voltage for i2c subchannels
Updating to regulator-sb3v3 

quoted

+		compatible = "regulator-fixed";
+		regulator-name = "fixed-3.3V";

The name should be something we can find on board schematics.

Sure, I will update SMPS name which provide fixed 3.3 stand-by voltage

quoted

+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-boot-on;
+		regulator-always-on;
+	};
+
+};
+
+&uart0 {
+	status = "okay";
+};
+
+&uart1 {
+	status = "okay";
+};
+
+&i2c0 {

Please keep these labeled nodes sorted alphabetically.

Ok

quoted

+	status = "okay";

Have a newline between properties and child node.

Sure.

quoted

+	i2c-mux@77 {
+		compatible = "nxp,pca9547";
+		reg = <0x77>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		i2c@2 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x2>;
+
+			power-monitor@40 {
+				compatible = "ti,ina220";
+				reg = <0x40>;
+				shunt-resistor = <1000>;
+			};
+		};
+
+		i2c@3 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x3>;
+
+			temperature-sensor@4c {
+				compatible = "nxp,sa56004";
+				reg = <0x4c>;
+				vcc-supply = <&sb_3v3>;
+			};
+
+			temperature-sensor@4d {
+				compatible = "nxp,sa56004";
+				reg = <0x4d>;
+				vcc-supply = <&sb_3v3>;
+			};
+		};
+	};
+};
+
+&i2c4 {
+	status = "okay";
+
+	rtc@51 {
+		compatible = "nxp,pcf2129";
+		reg = <0x51>;
+		// IRQ10_B
+		interrupts = <0 150 0x4>;
+		};

Bad indentation.

My mistake, Updated

Shawn

quoted

+
+};
+
+&usb0 {
+	status = "okay";
+};
+
+&usb1 {
+	status = "okay";
+};
+
+&crypto {
+	status = "okay";
+};
--
2.7.4