Hello,
On Wed, Oct 10, 2018 at 08:34:06AM -0700, Alexander Duyck wrote:
quoted
Maybe we wanna round-robin within the node?
I had thought about it. It adds extra complexity to do it and for
unbound work queues it doesn't really add anything since it gets
converted back into a node anyway.
Yeap, it only makes sense for per-cpu workqueues.
If you wanted I could look at adding extra logic that would do the
round-robin for non-unbound workqueues. I just wasn't sure if it was
worth the effort since the current users are all unbound workqueues.
It doesn't have to be complex, just a per-node unsynchronized int
which gets incremented and %'s would work fine. Alternatively, we can
trigger WARN_ON_ONCE() if the function is used on a per-cpu workqueue.
Thanks.
--
tejun