Re: [PATCH v1 02/10] dt-bindings: thermal: Fix a typo in documentation
From: Daniel Lezcano <hidden>
Date: 2018-08-31 08:14:27
Also in:
linux-arm-msm, linux-devicetree, lkml
From: Daniel Lezcano <hidden>
Date: 2018-08-31 08:14:27
Also in:
linux-arm-msm, linux-devicetree, lkml
On 25/08/2018 01:24, Eduardo Valentin wrote:
On Thu, Aug 09, 2018 at 06:02:34PM +0530, Amit Kucheria wrote:quoted
c(1) + x(1) was actually meant to be c(1) * x(1). While we're at it, add some brackets to make it nicer to read. Signed-off-by: Amit Kucheria <redacted> --- Documentation/devicetree/bindings/thermal/thermal.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt index cc553f0952c5..751104213d08 100644 --- a/Documentation/devicetree/bindings/thermal/thermal.txt +++ b/Documentation/devicetree/bindings/thermal/thermal.txt@@ -152,7 +152,7 @@ Optional property: Elem size: one cell the sensors listed in the thermal-sensors property. Elem type: signed Coefficients defaults to 1, in case this property is not specified. A simple linear polynomial is used: - Z = c0 * x0 + c1 + x1 + ... + c(n-1) * x(n-1) + cn. + Z = (c0 * x0) + (c1 * x1) + ... + (c(n-1) * x(n-1)) + cn.To be honest, I would prefer if this looks like: + Z = c0 * x0 + c1 * x1 + ... + c(n-1) * x(n-1) + cn. The extra bracketing seams unnecessary confusion
I agree, the brackets don't change the computation ordering, they are pointless. -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog