Thread (2 messages) 2 messages, 2 authors, 2018-08-25

Re: [PATCH] cpuidle: menu: Retain tick when shallow state is selected

From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: 2018-08-25 11:22:06
Also in: lkml

On Fri, Aug 24, 2018 at 5:52 PM Doug Smythies [off-list ref] wrote:
On 2018.08.24 02:44 Rafael J. Wysocki wrote:
quoted
On Tuesday, August 21, 2018 10:44:10 AM CEST Rafael J. Wysocki wrote:
quoted
From: Rafael J. Wysocki <redacted>

The case addressed by commit 5ef499cd571c (cpuidle: menu: Handle
stopped tick more aggressively) in the stopped tick case is present
when the tick has not been stopped yet too.
... [snip] ...
quoted
quoted
Fixes: 87c9fe6ee495 (cpuidle: menu: Avoid selecting shallow states with stopped tick)
... [snip] ...
quoted
Due to the lack of objections, I'm inclined to queue this up.
I have been following these threads.
Recall that I was involved, over a period of months, in the original
"powernightmare" stuff.
I have revived my tests (and wish I had left myself better notes), and
am establishing a baseline before adding and trying this patch.
My baseline is actually two tests with and without the previous two patches (the ones
that were just sent a couple of days ago in "More power management updates for v4.19-rc1".
I might have those results in some presentable form by later today (it looks O.K.)
Results with this patch will take another couple of days.
Thanks Doug, much appreciated!

This patch has been queued up, but I will wait for your results for a
few days before pushing it.

Cheers,
Rafael
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help