On 22-03-18, 11:18, Ulf Hansson wrote:

On 22 March 2018 at 10:59, Viresh Kumar [off-list ref] wrote:

quoted

On 22-03-18, 10:30, Ulf Hansson wrote:

quoted

On 22 December 2017 at 08:26, Viresh Kumar [off-list ref] wrote:

quoted

quoted

quoted

+       ret = device_add(&genpd->dev);

What's the point of adding the device? Can we skip this step, as I
guess the opp core is only using the device as cookie rather actual
using it? No?

We also use it for the OPP debugfs stuff, so that would be required I believe.

Right, however, isn't that only using the dev_name(dev), which you
don't need to add the device to make use of.

Or maybe I missing something around this...

So I tested this bit. The code works fine even if the device isn't added
(registered), but this looks a bit sloppy to attempt.

Please let me know what would you prefer in this case, add the device or not.

-- 
viresh