Thread (13 messages) 13 messages, 3 authors, 2017-12-26

Re: [PATCH 1/3] PM / core: Assign the wakeup_path status flag in __device_prepare()

From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: 2017-12-21 01:43:09
Also in: linux-renesas-soc

On Fri, Dec 15, 2017 at 4:56 PM, Ulf Hansson [off-list ref] wrote:
The PM core in the device_prepare() phase, resets the wakeup_path status
flag to the value of device_may_wakeup(). This means if a ->prepare() or a
->suspend() callback for the device would update the device's wakeup
setting, this doesn't become reflected in the wakeup_path status flag.

In general this isn't a problem, because wakeup settings isn't supposed to
be changed during those system suspend phases. Nevertheless, there are a
cases not conforming to that behaviour, as device_set_wakeup_enable() is
indeed called from ->suspend() callbacks.
And why is this regarded as correct?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help