Re: [PATCH] sched/autogroup: move sched.h include

From
Sergey Senozhatsky <hidden>
Date
2017-12-08 10:39:39
Also in
linux-mm, linux-pci, lkml
Reply to
Petr Mladek, 2017-12-08
Hi,

On (12/08/17 09:57), Petr Mladek wrote:
On Fri 2017-12-08 17:24:22, Sergey Senozhatsky wrote:
quoted
Move local "sched.h" include to the bottom. sched.h defines
several macros that are getting redefined in ARCH-specific
code, for instance, finish_arch_post_lock_switch() and
prepare_arch_switch(), so we need ARCH-specific definitions
to come in first.
This patch is needed to fix compilation error [1] caused by a patchset
that deprecates %pf/%pF printk modifiers[2].

IMHO, we should make sure that this fix goes into Linus' tree
before the printk-related patchset. What is the best practice,
please?
as long as sched pull request goes before printk pull request we
are fine. but I see your point.
I see two reasonable possibilities. Either sched people could
push this for-4.15-rcX. Or I could put it into printk.git for-4.16
in the right order.
agreed.
What do you think?
either way is fine with me. we can have it in print.git (no objections
from my side) or in sched tree and just make sure that sched pull request
has "bigger priority", or it can go to Linus's tree as a potential fix
(I'd prefer the last option, I think).

	-ss
Thread (30 messages) 30 messages, 9 authors, last reply 2017-12-18
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help