Re: [PATCH 1/4] rk3399_dmc: Fix line continuation format
From: Joe Perches <joe@perches.com>
Date: 2017-11-22 10:41:26
Also in:
lkml
On Wed, 2017-11-22 at 14:13 +0900, Chanwoo Choi wrote:
On 2017년 11월 17일 00:27, Joe Perches wrote:quoted
Line continuations with excess spacing causes unexpected output. Signed-off-by: Joe Perches <joe@perches.com> --- drivers/devfreq/rk3399_dmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c index 5dfbfa3cc878..0938c97d46f0 100644 --- a/drivers/devfreq/rk3399_dmc.c +++ b/drivers/devfreq/rk3399_dmc.c@@ -146,8 +146,8 @@ static int rk3399_dmcfreq_target(struct device *dev, unsigned long *freq, /* If get the incorrect rate, set voltage to old value. */ if (dmcfreq->rate != target_rate) { - dev_err(dev, "Get wrong ddr frequency, Request frequency %lu,\ - Current frequency %lu\n", target_rate, dmcfreq->rate); + dev_err(dev, "Get wrong ddr frequency, Request frequency %lu, Current frequency %lu\n", + target_rate, dmcfreq->rate);IMO, I don't like over 80 char in the one line.
Fix it as you chose, but the code I proposed is what is preferred by CodingStyle. The current code is unintentional. Right now there are 3 tabs between "Request frequency" and "Current frequency" in the output.
quoted
regulator_set_voltage(dmcfreq->vdd_center, dmcfreq->volt, dmcfreq->volt); goto out;