Re: [PATCH v3 4/6] PM / core: Add helpers for subsystem callback selection
From: Ulf Hansson <hidden>
Date: 2017-11-15 07:43:16
Also in:
linux-acpi, linux-pci, lkml
On 12 November 2017 at 01:42, Rafael J. Wysocki [off-list ref] wrote:
From: Rafael J. Wysocki <redacted> Add helper routines to find and return a suitable subsystem callback during the "noirq" phases of system suspend/resume (or analogous) transitions as well as during the "late" phase of system suspend and the "early" phase of system resume (or analogous) transitions. The helpers will be called from additional sites going forward. Signed-off-by: Rafael J. Wysocki <redacted>
With a minor nitpick, see below, feel free to add: Reviewed-by: Ulf Hansson <redacted>
quoted hunk ↗ jump to hunk
--- v2 -> v3: No changes. --- drivers/base/power/main.c | 196 +++++++++++++++++++++++++++++++--------------- 1 file changed, 136 insertions(+), 60 deletions(-) Index: linux-pm/drivers/base/power/main.c ===================================================================--- linux-pm.orig/drivers/base/power/main.c +++ linux-pm/drivers/base/power/main.c@@ -525,6 +525,14 @@ static void dpm_watchdog_clear(struct dp #define dpm_watchdog_clear(x) #endif +static pm_callback_t dpm_subsys_suspend_noirq_cb(struct device *dev, + pm_message_t state, + const char **info_p); + +static pm_callback_t dpm_subsys_suspend_late_cb(struct device *dev, + pm_message_t state, + const char **info_p); +
There is no need to declare these functions. Perhaps a following patch in the series need them, but then that change should add these or even better (in my opinion) just move the implementations and avoid the declarations all together. [...] Kind regards Uffe