Thread (4 messages) 4 messages, 4 authors, 2017-10-05

Re: [PATCH V2] Bug fix for PME interrupt handler, add Root Status check

From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: 2017-10-01 00:45:12
Also in: linux-pci

On Sat, Sep 30, 2017 at 4:12 AM, Qiang Zheng [off-list ref] wrote:
quoted hunk ↗ jump to hunk
PCIe PME and hot plug share same interrupt number. In some special case,
Link down event cause hot plug interrupt, devices is not disconnected,
But read config will return 0xff.

In that case, PME work function will run and not return Because
Root Status PME bit always 1 and can not be cleared.

This patch add Root Status check in PME interrupt handler,
Just do same as pciehp isr Slot status check.

Signed-off-by: Qiang Zheng <redacted>
---
 drivers/pci/pcie/pme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c
index fafdb16..2ff2e57 100644
--- a/drivers/pci/pcie/pme.c
+++ b/drivers/pci/pcie/pme.c
@@ -273,7 +273,7 @@ static irqreturn_t pcie_pme_irq(int irq, void *context)
        spin_lock_irqsave(&data->lock, flags);
        pcie_capability_read_dword(port, PCI_EXP_RTSTA, &rtsta);

-       if (!(rtsta & PCI_EXP_RTSTA_PME)) {
+       if (rtsta == U32_MAX || !(rtsta & PCI_EXP_RTSTA_PME)) {
                spin_unlock_irqrestore(&data->lock, flags);
                return IRQ_NONE;
        }
--
Reviewed-by: Rafael J. Wysocki <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help