Thread (21 messages) 21 messages, 2 authors, 2017-10-20

Re: [PATCH 01/18] thermal/drivers/hisi: Fix missing interrupt enablement

From: Daniel Lezcano <hidden>
Date: 2017-10-20 06:35:35
Also in: lkml

On 20/10/2017 03:52, Eduardo Valentin wrote:
On Thu, Oct 19, 2017 at 07:05:43PM +0200, Daniel Lezcano wrote:
quoted
The interrupt for the temperature threshold is not enabled at the end of the
probe function, enable it after the setup is complete.

On the other side, the irq_enabled is not correctly set as we are checking if
the interrupt is masked where 'yes' means irq_enabled=false.

	irq_get_irqchip_state(data->irq, IRQCHIP_STATE_MASKED,
				&data->irq_enabled);

As we are always enabling the interrupt, it is pointless to check if
the interrupt is masked or not, just set irq_enabled to 'true'.

Why only 18 patches this time? Can you please add a cover letter (0/X)
next time?
Yes sure.

Actually, I grouped the different series (acked and reviewed) into a git
pull request instead of having them around. I thought that could help
you. I sent a pull request with all these patches under this pull
request along with a description. Did you receive it? Note without the
threaded email view, it is easy to miss it.
What happened to the other 7 patches?
As stated in the PR, I put them apart to solve the multi threshold issue
before resubmitting, probably by folding Kevin's latest change. I will
resend them very shortly.

  -- Daniel


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help