Re: [PATCH 0/7 RESEND] turbostat: Fix AMD output by making turbostat aware of nodes
From: Len Brown <lenb@kernel.org>
Date: 2017-08-05 07:06:56
From: Len Brown <lenb@kernel.org>
Date: 2017-08-05 07:06:56
Hi Prarit, Thanks for re-sending to linux-pm -- much easier to track patches there:-) three suggestions. the package,core,cpu columns in turbostat are helpful for understanding topology. Now that you've taught turbostat about nodes, I think it would make sense to expose that knowledge in an additional "Node" column. In testing this patch series, I found that it now visits HT siblings in reverse order. I would prefer if the patch series did not change the displayed CPU order on existing systems, since there are existing data-sets and it would be good to be able to still be able to compare them... (also, I think it reads better to continue visit the lower numbered HT sibling before the higher numbered, rather than the reverse) please re-send after the patch series is checkpatch.pl clean thanks, Len Brown, Intel Open Source Technology Center