On 06/07/2017 09:51 AM, Ulf Hansson wrote:

On 26 May 2017 at 01:51, Thara Gopinath [off-list ref] wrote:

quoted

This patch extends the existing generic power domain debugfs.
Changes involve the following
- Remove the current flat format of displaying generic power domain
  summary.
- Introduce a unique debugfs entry for each generic power domain with the
  following attributes
        - current_state - Displays current state of the domain.
        - devices - Displays the devices associated with this domain.
        - slaves - Displays the sub power domains.

Maybe "sub_domains" is a better name for the node then?

quoted

        - on_time - Displays the time the domain was in on state in ms.

/s/on_time/active_time

quoted

        - idle_time - Displays the time the domain was in any of the idle
                        states in ms.

/s/idle_time/total_idle_time

quoted

        - idle_states - Displays the various idle states and the time
                        spent in each idle state in ms.

Signed-off-by: Thara Gopinath <redacted>

Besides the nitpicks above, this looks okay to me, however please
address Geerts comments as well.

Will fix all the above comments and re-send

[...]

Kind regards
Uffe

-- 
Regards
Thara