Thread (9 messages) 9 messages, 4 authors, 2017-07-17

Re: [PATCH] devfreq: tegra: fix error code in tegra_devfreq_probe()

From: Chanwoo Choi <cw00.choi@samsung.com>
Date: 2017-06-30 08:02:26
Also in: linux-tegra, lkml

Hi,

On 2017년 06월 30일 16:22, Gustavo A. R. Silva wrote:
quoted hunk ↗ jump to hunk
Print and propagate the return value of platform_get_irq on failure.

Signed-off-by: Gustavo A. R. Silva <redacted>
---
 drivers/devfreq/tegra-devfreq.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
index 214fff9..ae71215 100644
--- a/drivers/devfreq/tegra-devfreq.c
+++ b/drivers/devfreq/tegra-devfreq.c
@@ -688,9 +688,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
 	}
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq <= 0) {
-		dev_err(&pdev->dev, "Failed to get IRQ\n");
-		return -ENODEV;
+	if (irq < 0) {
+		dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq);
+		return irq;
 	}
 
 	platform_set_drvdata(pdev, tegra);
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help