Re: [PATCH v2 5/8] PM / Domains: Fix unsafe iteration over modified list of domain providers
From: Ulf Hansson <hidden>
Date: 2017-06-13 10:39:07
Also in:
lkml, stable
On 12 June 2017 at 17:17, Krzysztof Kozlowski [off-list ref] wrote:
of_genpd_del_provider() iterates over list of domain provides and
removes matching element thus it has to use safe version of list
iteration.
Fixes: aa42240ab254 ("PM / Domains: Add generic OF-based PM domain look-up")
Cc: <redacted>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>Acked-by: Ulf Hansson <redacted>
quoted hunk ↗ jump to hunk
--- drivers/base/power/domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index d1e438024e46..b74b5111957a 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c@@ -1789,12 +1789,12 @@ EXPORT_SYMBOL_GPL(of_genpd_add_provider_onecell); */ void of_genpd_del_provider(struct device_node *np) { - struct of_genpd_provider *cp; + struct of_genpd_provider *cp, *tmp; struct generic_pm_domain *gpd; mutex_lock(&gpd_list_lock); mutex_lock(&of_genpd_mutex); - list_for_each_entry(cp, &of_genpd_providers, link) { + list_for_each_entry_safe(cp, tmp, &of_genpd_providers, link) { if (cp->node == np) { /* * For each PM domain associated with the --2.9.3