RE: Re: [PATCH] devfreq: exynos-ppmu: Staticize event list

Hi Krzysztof,

On 2017년 06월 08일 03:12, Krzysztof Kozlowski wrote:

quoted

The ppmu_events array is accessed only in this compilation unit so it

quoted

can be made static.

quoted

quoted

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

quoted

---

quoted

 drivers/devfreq/event/exynos-ppmu.c | 2 +-

quoted

 1 file changed, 1 insertion(+), 1 deletion(-)

quoted

quoted

diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c

quoted

index 9b7350935b73..c68f3b5a10b5 100644

quoted

--- a/drivers/devfreq/event/exynos-ppmu.c

quoted

+++ b/drivers/devfreq/event/exynos-ppmu.c

quoted

@@ -44,7 +44,7 @@ struct exynos_ppmu {

quoted

 	{ "ppmu-event2-"#name, PPMU_PMNCNT2 },	\

quoted

 	{ "ppmu-event3-"#name, PPMU_PMNCNT3 }

quoted

quoted

-struct __exynos_ppmu_events {

quoted

+static struct __exynos_ppmu_events {

quoted

 	char *name;

quoted

 	int id;

quoted

 } ppmu_events[] = {

quoted

Looks good to me.

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>





Cheers,

MyungJoo