Thread (23 messages) 23 messages, 6 authors, 2017-06-06

Re: [PATCH 1/7] USB: core: fix device node leak

From: Peter Chen <hidden>
Date: 2017-06-05 03:35:41
Also in: lkml, stable

On Tue, May 30, 2017 at 06:25:48PM +0200, Johan Hovold wrote:
quoted hunk ↗ jump to hunk
Make sure to release any OF device-node reference taken when creating
the USB device.

Note that we currently do not hold a reference to the root hub
device-tree node (i.e. the parent controller node).

Fixes: 69bec7259853 ("USB: core: let USB device know device node")
Cc: stable <redacted>	# v4.6
Cc: Peter Chen <redacted>
Signed-off-by: Johan Hovold <redacted>
---
 drivers/usb/core/usb.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c
index 28b053cacc90..62e1906bb2f3 100644
--- a/drivers/usb/core/usb.c
+++ b/drivers/usb/core/usb.c
@@ -416,6 +416,8 @@ static void usb_release_dev(struct device *dev)
 
 	usb_destroy_configuration(udev);
 	usb_release_bos_descriptor(udev);
+	if (udev->parent)
+		of_node_put(dev->of_node);
 	usb_put_hcd(hcd);
 	kfree(udev->product);
 	kfree(udev->manufacturer);
Acked-by: Peter Chen <redacted>

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help