Re: [PATCH 4/4] PM / OPP: Don't create debugfs "supply-0" directory unnecessarily
From: Stephen Boyd <hidden>
Date: 2017-05-23 01:28:36
Also in:
lkml
On 05/17, Viresh Kumar wrote:
quoted hunk ↗ jump to hunk
We create "supply-0" debugfs directory even if the device doesn't do voltage scaling. That looks confusing, as if the regulator is found but we never managed to get voltage levels for it. Avoid creating such a directory unnecessarily. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/base/power/opp/debugfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/drivers/base/power/opp/debugfs.c b/drivers/base/power/opp/debugfs.c index 95f433db4ac7..ce6f4832946b 100644 --- a/drivers/base/power/opp/debugfs.c +++ b/drivers/base/power/opp/debugfs.c@@ -40,11 +40,11 @@ static bool opp_debug_create_supplies(struct dev_pm_opp *opp, struct dentry *pdentry) { struct dentry *d; - int i = 0; + int i = -1; char *name; /* Always create at least supply-0 directory */
Bad comment.
- do {
+ while (++i < opp_table->regulator_count) {This is a brain-melting while loop for what should be a for loop. Please just use a for loop instead of pre-incrementing -1 and comparing that to the unsigned type of regulator_count. i should probably be unsigned as well. I can only assume it was written as a do-while before because we assumed there was always some voltage to control. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project