Thread (55 messages) 55 messages, 4 authors, 2017-03-29

Re: [PATCH v2 6/7] power: supply: bq24190_charger: Cleanup error-exit labels in probe()

From: Tony Lindgren <tony@atomide.com>
Date: 2017-03-22 15:54:33

* Hans de Goede [off-list ref] [170322 07:57]:
Names like out1, out2, etc. do not make it easier to follow what is
going on and make it harder (require renaming) if any steps are
later added / removed. Rename the labels to sane names.

This also folds out1 and out2 into one pm_runtime_disable step,
if pm_runtime_get_sync fails we still need to do the put, it
failing means that the device failed to resume, but the refcount
will have been incremented and we need to decrement it.
Seems OK to me:

Acked-by: Tony Lindgren <tony@atomide.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help