Re: [PATCH v5 7/8] power: bq27xxx_battery: Define access methods to write chip registers
From: Andrew F. Davis <hidden>
Date: 2017-02-06 23:32:49
On 02/04/2017 03:16 AM, Liam Breck wrote:
quoted hunk ↗ jump to hunk
From: Liam <redacted> From: Matt Ranostay <redacted> write(), read_bulk(), write_bulk() support setting chip registers, e.g. with data obtained from power_supply_battery_info. Signed-off-by: Matt Ranostay <redacted> Signed-off-by: Liam Breck <redacted> --- include/linux/power/bq27xxx_battery.h | 3 +++ 1 file changed, 3 insertions(+)diff --git a/include/linux/power/bq27xxx_battery.h b/include/linux/power/bq27xxx_battery.h index c433815..1a78512 100644 --- a/include/linux/power/bq27xxx_battery.h +++ b/include/linux/power/bq27xxx_battery.h@@ -32,6 +32,9 @@ struct bq27xxx_platform_data { struct bq27xxx_device_info; struct bq27xxx_access_methods { int (*read)(struct bq27xxx_device_info *di, u8 reg, bool single); + int (*write)(struct bq27xxx_device_info *di, u8 reg, int value, bool single); + int (*read_bulk)(struct bq27xxx_device_info *di, u8 reg, u8 *data, int len); + int (*write_bulk)(struct bq27xxx_device_info *di, u8 reg, u8 *data, int len);
These should have been defined way earlier in the series, this will break bisectability. Andrew
};
struct bq27xxx_reg_cache {