Re: [PATCH 2/2] power: bq24190_charger: Use PM runtime autosuspend
From: Liam Breck <hidden>
Date: 2017-02-03 10:39:00
Also in:
linux-omap
On Mon, Jan 30, 2017 at 4:36 PM, Tony Lindgren [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Tony Lindgren <tony@atomide.com> Date: Mon, 30 Jan 2017 07:10:31 -0800 Subject: [PATCH] power: bq24190_charger: Use PM runtime autosuspend We can get quite a few interrupts when the battery is trickle charging. Let's enable PM runtime autosuspend to avoid constantly toggling device driver PM runtime state. Let's use a 600 ms timeout as that's how long the USB chager detection might take. Cc: Liam Breck <redacted> Acked-by: Mark Greer <mgreer@animalcreek.com> Signed-off-by: Tony Lindgren <tony@atomide.com> --- drivers/power/supply/bq24190_charger.c | 153 ++++++++++++++++++++++++--------- 1 file changed, 111 insertions(+), 42 deletions(-)diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c --- a/drivers/power/supply/bq24190_charger.c +++ b/drivers/power/supply/bq24190_charger.c...@@ -1234,11 +1267,15 @@ static void bq24190_check_status(struct bq24190_dev_info *bdi) static irqreturn_t bq24190_irq_handler_thread(int irq, void *data) { struct bq24190_dev_info *bdi = data; + int ret; bdi->irq_event = true; - pm_runtime_get_sync(bdi->dev); + ret = pm_runtime_get_sync(bdi->dev); + if (ret < 0) + return ret; bq24190_check_status(bdi); - pm_runtime_put_sync(bdi->dev); + pm_runtime_mark_last_busy(bdi->dev); + pm_runtime_put_autosuspend(bdi->dev); bdi->irq_event = false; return IRQ_HANDLED;
OK get_sync() failure should return error to userspace callers, and abort probe(), makes sense. But should the interrupt handler (above) emit a warning and continue as in resume() and suspend()? If not is ret the right value to return in lieu of irq_handled?