Thread (15 messages) 15 messages, 4 authors, 2017-02-16

Re: Regression in next with use printk_safe buffers in printk

From: Sergey Senozhatsky <hidden>
Date: 2017-02-16 04:24:43
Also in: lkml

On (02/15/17 20:03), Tony Lindgren wrote:
* Sergey Senozhatsky [off-list ref] [170215 17:32]:
quoted
On (02/15/17 10:01), Tony Lindgren wrote:
[..]
quoted
Below is another issue I noticed caused by commit f975237b7682 that
I noticed during booting.
do you mean that with f975237b7682 you _always_ see that illegal RCU
usage warning?
Yeah on every boot on devices using cpuidle_coupled.
does this mean that with the printk-safe patches reverted
(so, basically, the same conditions module 4 printk patches)
you don't see illegal RCU usage reports? at the moment I can't
see any connection between f975237b7682 and RCU usage from idle CPU.

[..]
quoted
---
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 7180088cbb23..34da86e73d00 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -1563,7 +1563,7 @@ static void call_console_drivers(const char *ext_text, size_t ext_len,
 {
 	struct console *con;
 
-	trace_console(text, len);
+	trace_console_rcuidle(text, len);
 
 	if (!console_drivers)
 		return;

---

I need to look more at this.
That fixes it for me thanks, so feel free to add:

Tested-by: Tony Lindgren <tony@atomide.com>
thanks.

	-ss
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help