Re: [PATCH] thermal/intel_powerclamp: Remove set-but-not-used variables
From: Jacob Pan <hidden>
Date: 2017-01-31 16:22:05
Also in:
lkml
On Mon, 30 Jan 2017 10:47:36 +0000 Augusto Mecking Caringi [off-list ref] wrote:
In poll_pkg_cstate() function, the variables jiffies_last and
jiffies_now are set but never used.
This has been detected by building the driver with W=1:
drivers/thermal/intel_powerclamp.c: In function ‘poll_pkg_cstate’:
drivers/thermal/intel_powerclamp.c:464:23: warning: variable
‘jiffies_last’ set but not used [-Wunused-but-set-variable]
static unsigned long jiffies_last;
^Acked-by: Jacob Pan <redacted> Thanks,
quoted hunk ↗ jump to hunk
Signed-off-by: Augusto Mecking Caringi <redacted> --- drivers/thermal/intel_powerclamp.c | 4 ---- 1 file changed, 4 deletions(-)diff --git a/drivers/thermal/intel_powerclamp.cb/drivers/thermal/intel_powerclamp.c index df64692..a47103a 100644--- a/drivers/thermal/intel_powerclamp.c +++ b/drivers/thermal/intel_powerclamp.c@@ -461,16 +461,13 @@ static void poll_pkg_cstate(struct work_struct*dummy) { static u64 msr_last; static u64 tsc_last; - static unsigned long jiffies_last; u64 msr_now; - unsigned long jiffies_now; u64 tsc_now; u64 val64; msr_now = pkg_state_counter(); tsc_now = rdtsc(); - jiffies_now = jiffies; /* calculate pkg cstate vs tsc ratio */ if (!msr_last || !tsc_last)@@ -485,7 +482,6 @@ static void poll_pkg_cstate(struct work_struct*dummy) /* update record */ msr_last = msr_now; - jiffies_last = jiffies_now; tsc_last = tsc_now; if (true == clamping)
[Jacob Pan]