Re: [PATCH 12/12] PM / OPP: Update Documentation to remove RCU specific bits

[PATCH 00/12] PM / OPP: Use kref and move away from RCU locking · Viresh Kumar <viresh.kumar@linaro.org> · 2016-12-07
[PATCH 07/12] PM / OPP: Update OPP users to put reference · Viresh Kumar <viresh.kumar@linaro.org> · 2016-12-07
Re: [PATCH 07/12] PM / OPP: Update OPP users to put reference · Chanwoo Choi <cw00.choi@samsung.com> · 2016-12-07
Re: [PATCH 07/12] PM / OPP: Update OPP users to put reference · Viresh Kumar <viresh.kumar@linaro.org> · 2016-12-08
Re: [PATCH 07/12] PM / OPP: Update OPP users to put reference · Chanwoo Choi <hidden> · 2017-01-21
[PATCH 08/12] PM / OPP: Take kref from _find_opp_table() · Viresh Kumar <viresh.kumar@linaro.org> · 2016-12-07
Re: [PATCH 08/12] PM / OPP: Take kref from _find_opp_table() · Stephen Boyd <hidden> · 2017-01-09
[PATCH 12/12] PM / OPP: Update Documentation to remove RCU specific bits · Viresh Kumar <viresh.kumar@linaro.org> · 2016-12-07
Re: [PATCH 12/12] PM / OPP: Update Documentation to remove RCU specific bits · Stephen Boyd <hidden> · 2017-01-09
Re: [PATCH 12/12] PM / OPP: Update Documentation to remove RCU specific bits · Viresh Kumar <viresh.kumar@linaro.org> · 2017-01-10
Re: [PATCH 12/12] PM / OPP: Update Documentation to remove RCU specific bits · Stephen Boyd <hidden> · 2017-01-13
[PATCH 09/12] PM / OPP: Move away from RCU locking · Viresh Kumar <viresh.kumar@linaro.org> · 2016-12-07
Re: [PATCH 09/12] PM / OPP: Move away from RCU locking · Stephen Boyd <hidden> · 2017-01-09
Re: [PATCH 09/12] PM / OPP: Move away from RCU locking · Viresh Kumar <viresh.kumar@linaro.org> · 2017-01-10
[PATCH 10/12] PM / OPP: Simplify _opp_set_availability() · Viresh Kumar <viresh.kumar@linaro.org> · 2016-12-07
Re: [PATCH 10/12] PM / OPP: Simplify _opp_set_availability() · Stephen Boyd <hidden> · 2017-01-10
[PATCH 11/12] PM / OPP: Simplify dev_pm_opp_get_max_volt_latency() · Viresh Kumar <viresh.kumar@linaro.org> · 2016-12-07
Re: [PATCH 11/12] PM / OPP: Simplify dev_pm_opp_get_max_volt_latency() · Stephen Boyd <hidden> · 2017-01-09
[PATCH 01/12] PM / OPP: Add per OPP table mutex · Viresh Kumar <viresh.kumar@linaro.org> · 2016-12-07
Re: [PATCH 01/12] PM / OPP: Add per OPP table mutex · Stephen Boyd <hidden> · 2017-01-09
[PATCH 03/12] PM / OPP: Return opp_table from dev_pm_opp_set_*() routines · Viresh Kumar <viresh.kumar@linaro.org> · 2016-12-07
Re: [PATCH 03/12] PM / OPP: Return opp_table from dev_pm_opp_set_*() routines · Stephen Boyd <hidden> · 2017-01-09
[PATCH 06/12] PM / OPP: Add 'struct kref' to struct dev_pm_opp · Viresh Kumar <viresh.kumar@linaro.org> · 2016-12-07
Re: [PATCH 06/12] PM / OPP: Add 'struct kref' to struct dev_pm_opp · Stephen Boyd <hidden> · 2017-01-09
Re: [PATCH 06/12] PM / OPP: Add 'struct kref' to struct dev_pm_opp · Viresh Kumar <viresh.kumar@linaro.org> · 2017-01-10
Re: [PATCH 06/12] PM / OPP: Add 'struct kref' to struct dev_pm_opp · Stephen Boyd <hidden> · 2017-01-13
Re: [PATCH 06/12] PM / OPP: Add 'struct kref' to struct dev_pm_opp · Viresh Kumar <viresh.kumar@linaro.org> · 2017-01-13
Re: [PATCH 06/12] PM / OPP: Add 'struct kref' to struct dev_pm_opp · Stephen Boyd <hidden> · 2017-01-19
[PATCH 02/12] PM / OPP: Add 'struct kref' to OPP table · Viresh Kumar <viresh.kumar@linaro.org> · 2016-12-07
Re: [PATCH 02/12] PM / OPP: Add 'struct kref' to OPP table · Stephen Boyd <hidden> · 2017-01-09
Re: [PATCH 02/12] PM / OPP: Add 'struct kref' to OPP table · Viresh Kumar <viresh.kumar@linaro.org> · 2017-01-10
Re: [PATCH 02/12] PM / OPP: Add 'struct kref' to OPP table · Stephen Boyd <hidden> · 2017-01-13
[PATCH 04/12] PM / OPP: Take reference of the OPP table while adding/removing OPPs · Viresh Kumar <viresh.kumar@linaro.org> · 2016-12-07
Re: [PATCH 04/12] PM / OPP: Take reference of the OPP table while adding/removing OPPs · Stephen Boyd <hidden> · 2017-01-09
[PATCH 05/12] PM / OPP: Use dev_pm_opp_get_opp_table() instead of _add_opp_table() · Viresh Kumar <viresh.kumar@linaro.org> · 2016-12-07
Re: [PATCH 05/12] PM / OPP: Use dev_pm_opp_get_opp_table() instead of _add_opp_table() · Stephen Boyd <hidden> · 2017-01-09
Re: [PATCH 00/12] PM / OPP: Use kref and move away from RCU locking · "Rafael J. Wysocki" <rafael@kernel.org> · 2016-12-07

From: Stephen Boyd <hidden>
Date: 2017-01-13 08:44:56
Also in: lkml

On 01/10, Viresh Kumar wrote:

quoted hunk ↗ jump to hunk

@@ -252,6 +252,7 @@ dev_pm_opp_get_freq - Retrieve the freq represented by the opp pointer.
                 if (!IS_ERR(max_opp) && !IS_ERR(requested_opp))
                        r = soc_test_validity(max_opp, requested_opp);
                 dev_pm_opp_put(max_opp);
+                dev_pm_opp_put(requested_opp);
                /* do other things */
         }
         soc_test_validity(..)

Please add your RBY if it looks fine to you now.

Sure.

Reviewed-by: Stephen Boyd <redacted>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help