Re: [PATCH][RFC v7] timekeeping: Ignore the bogus sleep time if pm_trace is enabled
From: Rafael J. Wysocki <hidden>
Date: 2016-11-11 01:19:58
Also in:
linux-rtc, lkml
On Thursday, November 10, 2016 10:26:09 AM John Stultz wrote:
On Wed, Nov 9, 2016 at 8:55 PM, Chen Yu [off-list ref] wrote:quoted
Previously we encountered some memory overflow issues due to the bogus sleep time brought by inconsistent rtc, which is triggered when pm_trace is enabled, and we have fixed it in recent kernel. However it's improper in the first place to call __timekeeping_inject_sleeptime() in case that pm_trace is enabled simply because that "hash" time value will wreckage the timekeeping subsystem. This patch is originally written by Thomas, which would bypass the bogus rtc interval when pm_trace is enabled. Meanwhile, if system succeed to resume back with pm_trace set, the users are warned to adjust the bogus rtc either by ntp-date or rdate, by resetting pm_trace_rtc_abused to false, otherwise above tools might not work as expected. Originally-from: Thomas Gleixner [off-list ref] Cc: "Rafael J. Wysocki" <redacted> Cc: John Stultz <redacted> Cc: Xunlei Pang <redacted> Cc: Ingo Molnar <redacted> Cc: Len Brown <redacted> Cc: "H. Peter Anvin" <redacted> Cc: Pavel Machek <redacted> Cc: Thomas Gleixner <redacted> Signed-off-by: Chen Yu <redacted>Looks ok to me. I'm queueing it up for testing. If no one objects (and I don't see any issues) I'll merge it to my tree and push it to -tip through Thomas.
No objections here, thanks John! Cheers, Rafael -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.