On Thu, Sep 22, 2016 at 3:26 PM, Chanwoo Choi [off-list ref] wrote:

Hello,

On 2016년 09월 21일 09:30, Axel Lin wrote:

quoted

The rest of the code uses ARRAY_SIZE to count the number of entries in
ppmu_events array. The NULL terminated entry makes ARRAY_SIZE return
off-by-one value.

Signed-off-by: Axel Lin <redacted>
---
 drivers/devfreq/event/exynos-ppmu.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
index f55cf0e..c9ffaf0 100644
--- a/drivers/devfreq/event/exynos-ppmu.c
+++ b/drivers/devfreq/event/exynos-ppmu.c

@@ -90,8 +90,6 @@ struct __exynos_ppmu_events {
      PPMU_EVENT(d1-cpu),
      PPMU_EVENT(d1-general),
      PPMU_EVENT(d1-rt),
-
-     { /* sentinel */ },
 };

 static int exynos_ppmu_find_ppmu_id(struct devfreq_event_dev *edev)

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

Chanwoo, do you feel comfortable with removing this sentinel? (you are
never going to rely on the sentinel in the future or in external codes
as well?)
Actually, although ppmu-event is using ARRAY_SIZE, because the loops
are looking for valid name, the correctness is not damaged.

Assuming yes, Acked-by: MyungJoo Ham [off-list ref]

--
Best Regards,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
MyungJoo Ham, Ph.D.
Frontier CS Lab, S/W Center, Samsung Electronics