Re: [PATCH] thermal: armada: add support for suspend/resume
From: Mason <hidden>
Date: 2016-09-07 08:05:47
On 21/07/2016 12:43, Grzegorz Jaszczyk wrote:
quoted hunk ↗ jump to hunk
There is no need to implement subroutine for suspend since there is no data to store before suspending. Signed-off-by: Grzegorz Jaszczyk <redacted> --- drivers/thermal/armada_thermal.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c index ae75328..65f9838 100644 --- a/drivers/thermal/armada_thermal.c +++ b/drivers/thermal/armada_thermal.c@@ -304,12 +304,26 @@ static int armada_thermal_exit(struct platform_device *pdev) return 0; } +static int armada_thermal_resume(struct device *dev) +{ + struct thermal_zone_device *thermal = + dev_get_drvdata(dev); + struct armada_thermal_priv *priv = thermal->devdata; + + priv->data->init_sensor(to_platform_device(dev), priv); + + return 0; +} + +static SIMPLE_DEV_PM_OPS(armada_thermal_pm_ops, NULL, armada_thermal_resume); + static struct platform_driver armada_thermal_driver = { .probe = armada_thermal_probe, .remove = armada_thermal_exit, .driver = { .name = "armada_thermal", .of_match_table = armada_thermal_id_table, + .pm = &armada_thermal_pm_ops, }, };
gcc might warn about 'armada_thermal_resume' defined but not used when CONFIG_PM_SLEEP is not defined, I think? (I have a similar patch, Arnd suggested using __maybe_unused tag.) Regards.