Re: [PATCH v2 4/4] power: sbs-battery: Use gpio_desc and sleeping calls for battery detect
From: Sebastian Reichel <sre@kernel.org>
Date: 2016-08-15 21:09:01
Attachments
- signature.asc [application/pgp-signature] 819 bytes
From: Sebastian Reichel <sre@kernel.org>
Date: 2016-08-15 21:09:01
Hi Phil, On Mon, Jul 25, 2016 at 10:43:00AM +0800, Phil Reid wrote:
Switch to using new gpio_desc interface and devm gpio get calls to automatically manage gpio resource. Use gpiod_get_value which handles active high / low calls. If gpio_detect is set then force loading of the driver as it is reasonable to assume that the battery may not be present. Update the is_present flag immediately in the IRQ.
I queued PATCH 1-3. Please send a new revision for PATCH 4 (this one) with the following changes: * add the correct gpiod include: <include/linux/gpio/consumer.h> * rebase on power-supply's next branch * remove battery_detect and battery_detect_present from the struct sbs_platform_data and always use the gpiod API. It's data can also come from platform data, see Documentation/gpio/board.txt and Documentation/gpio/consumer.txt -- Sebastian