On Friday, August 19, 2016 7:29:56 PM CEST Zhang Rui wrote:

On 二, 2016-07-26 at 14:13 +0200, Arnd Bergmann wrote:

quoted

On Monday, July 25, 2016 11:48:47 AM CEST Mason wrote:

quoted

On 25/07/2016 10:52, Arnd Bergmann wrote:

quoted

On Monday, July 25, 2016 10:18:22 AM CEST Mason wrote:

quoted

Moving the SIMPLE_DEV_PM_OPS macro outside the CONFIG_PM_SLEEP
guard
would unconditionally define a struct dev_pm_ops, which just
wastes
space when CONFIG_PM_SLEEP is undefined (if I'm not mistaken).

That's why I put SIMPLE_DEV_PM_OPS inside the CONFIG_PM_SLEEP
guard.

If you want to avoid the extra few bytes, just use the trick I
suggested:

      .pm = IS_ENABLED(CONFIG_PM_SLEEP) ? &tango_thermal_pm :
NULL,

This would achieve the same result as the solution I proposed
in my v2 patch, right?

So you're saying you prefer the IS_ENABLED macro over using
#ifdef ... #else define stuff as NULL #endif

Did I get that right?

Yes, but I'd also prefer not to hide the operations structure
at all and just rely on the __maybe_unused (ideally) or
#ifdef (not as good, but commonly used) to leave out the
functions.

IMO, the typical way is to use #ifdef for the pm callbacks, and leave
SIMPLE_DEV_PM_OPS outside the #ifdef.
For example, drivers/ata/ahci_imx.c.

Lots of drivers do it like that, the main downside I see is that a
lot of them also get it wrong and use incorrect #ifdef guards,
either checking the wrong Kconfig symbol, or hiding the wrong
subset of functions.

	Arnd