Thread (5 messages) 5 messages, 2 authors, 2016-08-29

Re: [PATCH 1/2] power: bq24735-charger: Request status GPIO with initial input setup

From: Paul Kocialkowski <hidden>
Date: 2016-08-29 18:13:42
Also in: linux-tegra, lkml

Le lundi 29 août 2016 à 02:36 +0200, Sebastian Reichel a écrit :
Hi,

On Sun, Aug 28, 2016 at 07:34:45PM +0200, Paul Kocialkowski wrote:
quoted
This requests the status GPIO with initial input setup. it is required
to read the GPIO status at probe time and thus correctly avoid sending
i2c messages when AC is not plugged.

When requesting the GPIO without initial input setup, it always reads 0
which causes probe to fail as it assumes the charger is connected, sends
i2c messages and fails.
Please convert the driver to devm_gpiod_get instead.
Sure thing, see v2.

Thanks!

-- 
Paul Kocialkowski, developer of low-level free software for embedded devices

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help