Thread (6 messages) 6 messages, 4 authors, 2016-06-01

Re: [PATCH] thermal: cpu_cooling: fix improper order during initialization

From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2016-06-01 13:39:42

On 01-06-16, 14:31, Lukasz Luba wrote:

On 01/06/16 12:10, Viresh Kumar wrote:
quoted
On 31-05-16, 11:32, Lukasz Luba wrote:
quoted
The freq_table array is not populated before calling
thermal_of_cooling_register. The code which populates the freq table was
introduced in commit f6859014.
This should be done before registering new thermal cooling device.
The log shows effects of this wrong decision.
[    2.172614] cpu cpu1: Failed to get voltage for frequency 1984518656000: -34
[    2.220863] cpu cpu0: Failed to get voltage for frequency 1984524416000: -34
You should have added this as well:

Cc: 4.19+ <redacted> # 4.19+
You mean 3.19+
Cc: <redacted> # 3.19+
Urg.

Thanks for fixing this :)

-- 
viresh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help