When the pm_runtime_force_suspend|resume() helpers were invented, we still
had CONFIG_PM_RUNTIME and CONFIG_PM_SLEEP as separate Kconfig options.
To make sure these helpers worked for all combinations and without
introducing too much of complexity, the device was always resumed in
pm_runtime_force_resume().
More precisely, when CONFIG_PM_SLEEP was set and CONFIG_PM_RUNTIME was
unset, we needed to resume the device as the subsystem/driver couldn't
rely on using runtime PM to do it.
As the CONFIG_PM_RUNTIME option was merged into CONFIG_PM a while ago, it
removed this combination, of using CONFIG_PM_SLEEP without the earlier
CONFIG_PM_RUNTIME.
For this reason we can now rely on the subsystem/driver to use runtime PM
to resume the device, instead of forcing that to be done in all cases. In
other words, let's defer the runtime resume to a later point when it's
actually needed.
Signed-off-by: Ulf Hansson <redacted>
---
Changes in v2:
- Updated changelog.
- Updated comment in the code.
---
drivers/base/power/runtime.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c
index 09e4eb1..81731a2 100644
--- a/drivers/base/power/runtime.c
+++ b/drivers/base/power/runtime.c
@@ -1509,6 +1509,17 @@ int pm_runtime_force_resume(struct device *dev)
if (!pm_runtime_status_suspended(dev))
goto out;
+ /*
+ * The PM core increases the runtime PM usage count in the system PM
+ * prepare phase. If the count is greater than 1 at this point, a real
+ * user (such as a subsystem, driver, userspace, etc.) has also
+ * increased it, indicating that the device was used when system suspend
+ * was invoked. In this case, the device is expected to be used on
+ * system resume as well, so invoke the ->runtime_resume() callback.
+ */
+ if (atomic_read(&dev->power.usage_count) < 2)
+ goto out;
+
ret = pm_runtime_set_active(dev);
if (ret)
goto out;
--
1.9.1