Re: [PATCH 2/2] PM / Domains: Fix potential NULL pointer dereference
From: Ulf Hansson <hidden>
Date: 2016-03-04 11:07:23
Also in:
linux-tegra
On 4 March 2016 at 11:55, Jon Hunter [off-list ref] wrote:
In the function of_genpd_get_from_provider(), we never check to see if the argument 'genpdspec' is NULL before dereferencing it. Add error checking to handle any NULL pointers. Signed-off-by: Jon Hunter <redacted>
Acked-by: Ulf Hansson <redacted> Kind regards Uffe
quoted hunk
--- drivers/base/power/domain.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index ea9f2aa3fc33..5bdb42bf40f4 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c@@ -1686,6 +1686,9 @@ struct generic_pm_domain *of_genpd_get_from_provider( struct generic_pm_domain *genpd = ERR_PTR(-ENOENT); struct of_genpd_provider *provider; + if (!genpdspec) + return ERR_PTR(-EINVAL); + mutex_lock(&of_genpd_mutex); /* Check if we have such a provider in our array */ --2.1.4