Thread (4 messages) 4 messages, 2 authors, 2016-03-23
STALE3766d

[PATCH 2/2] ACPI / PM: Runtime resume devices when waking from hibernate

From: Lukas Wunner <lukas@wunner.de>
Date: 2016-03-22 23:11:20
Also in: linux-acpi
Subsystem: acpi, the rest · Maintainers: "Rafael J. Wysocki", Linus Torvalds

Commit 58a1fbbb2ee8 ("PM / PCI / ACPI: Kick devices that might have been
reset by firmware") added a runtime resume for devices that were runtime
suspended when the system entered suspend-to-RAM.

Briefly, the motivation was to ensure that devices did not remain in a
reset-power-on state after resume, potentially preventing deep SoC-wide
low-power states from being entered on idle.

Currently we're not doing the same when leaving suspend-to-disk and this
asymmetry is a problem if drivers rely on the automatic resume triggered
by pm_complete_with_resume_check(). Fix it.

Fixes: 58a1fbbb2ee8 ("PM / PCI / ACPI: Kick devices that might have been
    reset by firmware")
Signed-off-by: Lukas Wunner <lukas@wunner.de>
---
 drivers/acpi/sleep.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
index fbfcce3..2a8b596 100644
--- a/drivers/acpi/sleep.c
+++ b/drivers/acpi/sleep.c
@@ -748,6 +748,7 @@ static int acpi_hibernation_enter(void)
 
 static void acpi_hibernation_leave(void)
 {
+	pm_set_resume_via_firmware();
 	/*
 	 * If ACPI is not enabled by the BIOS and the boot kernel, we need to
 	 * enable it here.
-- 
1.8.5.2 (Apple Git-48)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help