Thread (6 messages) 6 messages, 3 authors, 2016-02-21

Re: [PATCH v12 0/3] Multiple intermediate states for genpd

From: Rafael J. Wysocki <hidden>
Date: 2016-02-21 17:41:14

On Monday, February 15, 2016 02:29:28 PM Ulf Hansson wrote:
On 15 February 2016 at 11:10,  [off-list ref] wrote:
quoted
From: Axel Haslam <redacted>

Some architectures may have intermediate power levels between on and off.

This patch set adds the ability to declare multiple states for a given
generic power domain, the idea is that the deepest state will be entered
which does not violate any of the device or sub-domain latency constraints.

Changes since v11
* Use static array of state instead of dynamic allocation

Changes since v10
* Several reworks after Ulf Hansson's comments:
 - merge the governor changes and core changes into a single patch
 - remove the "name" of the state.
 - add a default state allocation function
 - convert governor power done ok function to while loop.
 - reword commit message
*rebased on next-20160205

Changes since v9
*rebased on linux-next

Changes since v8
* rebased to linux-pm next

Changes since v7:
* rebase to 4.3-rc5

* add genpd_init_simple (Lina's suggestion) for platforms that don't have
multiple states and don't declare initial latencies. A default OFF
state with initial 0 latencies will be used in this case.

* Append Mark's patch to add "states" and "timings" to the genpd
debugfs

Changes since v6:
* change int to unsigned int were appropriate.

* spelling mistakes, and fix commit message for removal of latencies.

Changes since v5:
* rebase to 4.1-rc1

* Pass state array as an init argument on pm_genpd_init

* declare a default OFF state with no latencies, that will be used if a
null state argument is given.

* set the deepest state when using sync_poweroff.

* create and use name allocation function in the debug area
instead of inline.

Changes since v4:
* move to power_on/off callbacks out of the state array Platforms can
check the state_idx to know what state the power on/off corresponds to.

* convert states to pointer,
Dynamically allocate the states array to save memory on platforms
with several power domains.

* rename target_state to state_idx and remove init_state.

Changes since v3:
* remove old power on/off function at the end of the
series so that compilation will not break in between.

Changes since v2:
* remove state argument and macros from save/restore callbacks.

* added init_state for platforms to pass the initial state when the genpd
is initially off.

* convert current genpd users for the structure changes.

Changes since v1:
* split the changes so that the actual logic that selects the target state
is a separate patch.

* move the cached logic out of the state function and add
it back to default_power_down_ok.

* rename default_power_down_ok_state to power_down_ok_for_state
Axel Haslam (3):
  PM / Domains: Support for multiple states
  ARM: imx6: pm: declare pm domain latency on power_state struct.
  PM / Domains: remove old power on/off latencies.

 arch/arm/mach-imx/gpc.c              |  9 +++--
 drivers/base/power/domain.c          | 33 ++++++++++++++++---
 drivers/base/power/domain_governor.c | 64 ++++++++++++++++++++++--------------
 include/linux/pm_domain.h            | 13 ++++++--
 4 files changed, 86 insertions(+), 33 deletions(-)

--
2.6.3
For the series;

Acked-by: Ulf Hansson <redacted>
OK, queued up for 4.6, thanks!

Rafael
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help